bakabtw/packages
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[packages] mini-snmpd: fix use of uninitialized memory leading to garbage values (#10168)

Browse Source 
git-svn-id: svn://svn.openwrt.org/openwrt/packages@28358 3c298f89-4303-0410-b956-a3cf2f4a3e73
This commit is contained in:
jow 2011-10-03 09:22:46 +00:00
parent dfa9c366bc
commit 56f456f3e8
3 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/mini_snmpd/Makefile
View File

@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=mini_snmpd
PKG_VERSION:=1.2b
PKG_RELEASE:=2
PKG_RELEASE:=3
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=http://members.aon.at/linuxfreak/linux/

34
net/mini_snmpd/patches/102-mib_fix_uninitialized_memory.patch Normal file
View File

@ -0,0 +1,34 @@
--- a/mib.c
+++ b/mib.c
@@ -290,6 +290,7 @@ static int mib_build_entry(const oid_t *
value->data.max_length = sizeof (int) + 2;
value->data.encoded_length = 0;
value->data.buffer = malloc(value->data.max_length);
+ memset(value->data.buffer, 0, value->data.max_length);
if (encode_snmp_element_integer(value, (int)default_value) == -1) {
return -1;
}
@@ -298,6 +299,7 @@ static int mib_build_entry(const oid_t *
value->data.max_length = strlen((const char *)default_value) + 4;
value->data.encoded_length = 0;
value->data.buffer = malloc(value->data.max_length);
+ memset(value->data.buffer, 0, value->data.max_length);
if (encode_snmp_element_string(value, (const char *)default_value) == -1) {
return -1;
}
@@ -306,6 +308,7 @@ static int mib_build_entry(const oid_t *
value->data.max_length = MAX_NR_SUBIDS * 5 + 4;
value->data.encoded_length = 0;
value->data.buffer = malloc(value->data.max_length);
+ memset(value->data.buffer, 0, value->data.max_length);
if (encode_snmp_element_oid(value, oid_aton((const char *)default_value)) == -1) {
return -1;
}
@@ -316,6 +319,7 @@ static int mib_build_entry(const oid_t *
value->data.max_length = sizeof (unsigned int) + 2;
value->data.encoded_length = 0;
value->data.buffer = malloc(value->data.max_length);
+ memset(value->data.buffer, 0, value->data.max_length);
if (encode_snmp_element_unsigned(value, type, (unsigned int)default_value) == -1) {
return -1;
}

4
net/mini_snmpd/patches/103-mib_encode_snmp_element_oid_fix.patch
View File

@ -10,9 +10,9 @@
buffer = value->data.buffer;
length = 1;
for (i = 2; i < oid_value->subid_list_length; i++) {
@@ -307,6 +310,8 @@ static int mib_build_entry(const oid_t *
value->data.encoded_length = 0;
@@ -310,6 +313,8 @@ static int mib_build_entry(const oid_t *
value->data.buffer = malloc(value->data.max_length);
memset(value->data.buffer, 0, value->data.max_length);
if (encode_snmp_element_oid(value, oid_aton((const char *)default_value)) == -1) {
+ lprintf(LOG_ERR, "could not create MIB entry '%s.%d.%d': invalid oid '%s'\n",
+ oid_ntoa(prefix), column, row, (char *)default_value);