batman-adv: yet another critical bug fix
Forgot to add this one during the last round. Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> git-svn-id: svn://svn.openwrt.org/openwrt/packages@28474 3c298f89-4303-0410-b956-a3cf2f4a3e73
This commit is contained in:
parent
f346e26475
commit
c2c00d2b0a
@ -0,0 +1,36 @@
|
|||||||
|
From: Antonio Quartulli <ordex@autistici.org>
|
||||||
|
|
||||||
|
In the TT_RESPONSE packet, the number of carried entries is not correctly set.
|
||||||
|
This leads to a wrong interpretation of the packet payload on the receiver side
|
||||||
|
causing random entries to be added to the global translation table. Therefore
|
||||||
|
the latter gets always corrupted, triggering a table recovery all the time.
|
||||||
|
|
||||||
|
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
|
||||||
|
---
|
||||||
|
translation-table.c | 5 ++++-
|
||||||
|
1 files changed, 4 insertions(+), 1 deletions(-)
|
||||||
|
|
||||||
|
--- a/translation-table.c
|
||||||
|
+++ b/translation-table.c
|
||||||
|
@@ -1054,7 +1054,6 @@ static struct sk_buff *tt_response_fill_table(uint16_t tt_len, uint8_t ttvn,
|
||||||
|
tt_response = (struct tt_query_packet *)skb_put(skb,
|
||||||
|
tt_query_size + tt_len);
|
||||||
|
tt_response->ttvn = ttvn;
|
||||||
|
- tt_response->tt_data = htons(tt_tot);
|
||||||
|
|
||||||
|
tt_change = (struct tt_change *)(skb->data + tt_query_size);
|
||||||
|
tt_count = 0;
|
||||||
|
@@ -1080,6 +1079,10 @@ static struct sk_buff *tt_response_fill_table(uint16_t tt_len, uint8_t ttvn,
|
||||||
|
}
|
||||||
|
rcu_read_unlock();
|
||||||
|
|
||||||
|
+ /* store in the message the number of entries we have successfully
|
||||||
|
+ * copied */
|
||||||
|
+ tt_response->tt_data = htons(tt_count);
|
||||||
|
+
|
||||||
|
out:
|
||||||
|
return skb;
|
||||||
|
}
|
||||||
|
--
|
||||||
|
1.7.3.4
|
||||||
|
|
@ -13,8 +13,6 @@ Acked-by: Junkeun Song <jun361@gmail.com>
|
|||||||
translation-table.c | 2 ++
|
translation-table.c | 2 ++
|
||||||
1 files changed, 2 insertions(+), 0 deletions(-)
|
1 files changed, 2 insertions(+), 0 deletions(-)
|
||||||
|
|
||||||
diff --git a/translation-table.c b/translation-table.c
|
|
||||||
index 2d2cfc1..d4a3917 100644
|
|
||||||
--- a/translation-table.c
|
--- a/translation-table.c
|
||||||
+++ b/translation-table.c
|
+++ b/translation-table.c
|
||||||
@@ -1727,6 +1727,8 @@ static void tt_local_reset_flags(struct bat_priv *bat_priv, uint16_t flags)
|
@@ -1727,6 +1727,8 @@ static void tt_local_reset_flags(struct bat_priv *bat_priv, uint16_t flags)
|
||||||
|
Loading…
x
Reference in New Issue
Block a user